Cleaned up duplicate dynamic type functions #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
labels |
AlexOn1ine
reviewed
Sep 8, 2024
AlexOn1ine
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidated both dynamic-type functions into a single one, separating logic based on
gMain.inBattle.Note: because
gBattleStruct->ateBoostwas being set during the "in battle" version of the function, this consolidated version has anateBoostargument that acceptsNULLto tell it to not do so in the summary in battles and such.Images
Tested in-game that dynamic move types still worked in UIs.
Discord contact info
AsparagusEduardo