Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Defog used by the wrong side when there is a Substitue and Screen #5381

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

AlexOn1ine
Copy link
Collaborator

Fixes #5376

@hedara90 hedara90 added category: battle-mechanic Pertains to battle mechanics bugfix Bugfixes labels Sep 13, 2024
@hedara90
Copy link
Collaborator

This looks good.
Only comment I have is that Defog shouldn't lower evasion in gen 5+ on targets behind Substitutes. But that might be out of scope for this PR.

@AlexOn1ine
Copy link
Collaborator Author

This looks good. Only comment I have is that Defog shouldn't lower evasion in gen 5+ on targets behind Substitutes. But that might be out of scope for this PR.

I looked into this and this seems a bit broken. There is actually a substitute check but it doesn't work. Can we merge this and open an issue for the substitute issue? I don't want t dwell to much on this right now

@hedara90 hedara90 merged commit fbea1e7 into rh-hideout:upcoming Sep 14, 2024
1 check passed
@AlexOn1ine AlexOn1ine deleted the defogBattler branch November 21, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants