Revival Blessing fixes + Using Lunar Blessing's animation #5490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AsparagusEduardo revival blessing PR to master is ready |
Closed
|
Looks good but the animation is broken
|
|
Lunar Blessing's animation is also broken and imo an already broken animation should not be preventing this bugfix from being merged |
|
Please wait until I PR the test improvements to support Revival Blessing |
added 2 commits
October 14, 2024 13:58
…pansion into be/revivalblessing_master
Pawkkie
added
category: battle-mechanic
|
animation fixed in 469d533, waiting for edu's PR |
|
Forgot to post it here, but PR is ready: ghoulslash#25 |
…ing_master Added support for Revival Blessing in tests
|
added edu's PR, ready for review |
AsparagusEduardo
approved these changes
Oct 19, 2024
AsparagusEduardo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5471 but targeting master
Also fixes animation