Shed Skin chance fix #5558
Merged
Shed Skin chance fix #5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
reviewed
Oct 23, 2024
src/battle_util.c
Outdated
| @@ -5019,7 +5019,7 @@ u32 AbilityBattleEffects(u32 caseID, u32 battler, u32 ability, u32 special, u32 | |||
| break; | |||
| case ABILITY_SHED_SKIN: | |||
| if ((gBattleMons[battler].status1 & STATUS1_ANY) | |||
| && (B_ABILITY_TRIGGER_CHANCE >= GEN_4 ? RandomPercentage(RNG_SHED_SKIN, 30) : RandomChance(RNG_SHED_SKIN, 1, 3))) | |||
| && (B_ABILITY_TRIGGER_CHANCE == GEN_4 ? RandomPercentage(RNG_SHED_SKIN, 30) : RandomPercentage(RNG_SHED_SKIN, 33))) | |||
There was a problem hiding this comment.
Isn't 1 in 3 more accurate then 33%?
There was a problem hiding this comment.
Oh sure I suppose it is, I will revert that part :)
AlexOn1ine
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is maybe the pettiest looking PR I've ever made, but I realized this was "broken" while writing tests for the sleep clause branch iriv and I are working on.
Shed Skin triggers 30% of the time in Gen 4, and 1/3 of the time otherwise, according to Bulbapedia. As is, it triggers 30% of the time with configs set to Gen 4 or higher.
Gotta get that sweet sweet 3% proc chance
and fix my sleep clause testDiscord contact info
Pawkkie