Combines CalculateMoveDamage arguments into a struct #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedara90
added
category: battle-ai
Pawkkie
approved these changes
Oct 29, 2024
AlexOn1ine
added a commit
to AlexOn1ine/pokeemerald-expansion-1
that referenced
this pull request
Oct 31, 2024
AlexOn1ine
added a commit
that referenced
this pull request
Oct 31, 2024
ivaantxo
pushed a commit
to ivaantxo/pokeemerald
that referenced
this pull request
Nov 11, 2024
ivaantxo
pushed a commit
to ivaantxo/pokeemerald
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial motivation for this change was the growing number of arguments in
CalculateMoveDamagebecause If you wanted to add a single bool you had to modify every function call. The unification into a struct simplifies that because you only need to pass one argument. A nice bonus is that it makes function calls slightly faster. The speed gain will certainly not be visible in singles and I doubt it will have any affect on doubles but on average speed is improved by 2 frames in a multi battle. A third point which is subjective but I find it much more readable.Also I did some minor changes for
SetBattlerAiMovesDatabecause some stuff was checked multiply times when you only needed it to check once for every loop iteration.