Fixed Shiny Pokemon not being shiny after transforming with a gimmick #5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedara90
added
category: battle-mechanic
tertu-m
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an additional check to see if the task being executed is a Mega Evolution derived gimmick and runs the proper branch if that's the case instead of checking the shiny status of the opponent to decide Form shinyness.
Images
shinyPlayer.mp4
shinyOpponent.mp4
Issue(s) that this PR fixes
Fixes #5571
Feature(s) this PR does NOT handle:
Ultra Burst animation showing the Necrozma sprite before it should.
Discord contact info
hedara