Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary dependency scanning for test build and test rom names #5594

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

ravepossum
Copy link

Description

This fixes unnecessary extra dependency scanning currently being performed by the Makefile that's slowing down builds quite a bit. It occurs on every build, not just test ones.

The changes are based on the ones in this pret PR from pfero.

It also fixes the test ROM names erroneously including "agbcc" (which was causing them to not get caught by make clean).

Issue(s) that this PR fixes

  • Builds being slow after the recent makefile merged (notable by multiple people in discord)

Discord contact info

ravepossum

Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone else should confirm that the Makefile has no issues, but I can at least confirm a big increase in speed (using 16 threads).

Before

real    1m27.489s
user    6m8.390s
sys     0m45.279s

After

real    0m53.457s
user    4m46.168s
sys     0m34.685s

@AsparagusEduardo AsparagusEduardo added this to the 1.10 milestone Oct 27, 2024
@AsparagusEduardo AsparagusEduardo added type: sync Syncing with pret's upstream bugfix Bugfixes labels Oct 27, 2024
Copy link
Collaborator

@hedara90 hedara90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is much faster.
sha1sum of built rom doesn't change.
sha1sum of built tests doesn't change.

@hedara90 hedara90 merged commit 1a1270a into rh-hideout:master Oct 27, 2024
1 check passed
@ravepossum ravepossum deleted the makefile_tests_fix branch October 27, 2024 12:47
@AsparagusEduardo AsparagusEduardo added the General Doesn't fit under other labels label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes General Doesn't fit under other labels type: sync Syncing with pret's upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants