Fix Order Up + Tera Stellar breaking each other with Commander #5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedara90
added
category: battle-mechanic
AlexOn1ine
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issues occur if the Dondozo is on the right slot (player or opponent) only:
These happen because
gBattleStructdoesn't have enough space to storecommanderActivefor all battlers, so, as shown in the example program below, it instead stores on the next one (stellarBoostFlags).In a situation where both would be in use at the same time (example, Tera Stellar Dondozo affected by Commander on the right slot), both would modify the value stored, breaking the other's functionality.
This PR fixes these issues by giving proper space to store
commanderActivefor all battlers.Discord contact info
PhallenTree