Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followers sprite fixes #5669

Merged
merged 5 commits into from
Nov 17, 2024
Merged

Followers sprite fixes #5669

merged 5 commits into from
Nov 17, 2024

Conversation

Cafeei
Copy link

@Cafeei Cafeei commented Nov 13, 2024

A few more fixes for followers sprites

Fixed

  • Tepig blinking on all shiny
  • Pignite not great colors + broken shiny palette
  • Emboar blinking on north and south + broken shiny palette + north and west walking could use some tweaking
  • Watchog blinking + face and jacket should be different colors + should have white gloves
  • Herdier blinking
  • Purrloin shiny wrong eye color + blinking on west
  • Liepard east/west blinking, eyes could use better coloring
  • Audino tail is visible only in one west frame
  • Pansage + Pansear + Panpour have waaay too big eyes + their whole families’ west walking cycle could use some tweaking
  • Munna blinking on west shiny + wrong eye color on south
  • Musharna not great colors + stray pixels on north and south + shiny smoke could use better secondary color
  • Pidove blinking on south shiny
  • Boldore follower front legs look strange on east/west sprite
  • Gigalith follower east/west walk cycle looks strange, blinking on north
  • Drilbur blinking on north and south
  • Tympole doesn’t move
  • Palpitoad shiny could use brighter orange
  • Cottonee normal and shiny wrong eye color
  • Whimsicott blinking on south and north + weird west walking cycle + wrong eye color

Images

tepig_old -> tepig_new
pignite_old2 -> pignite_new2
pignite_old -> pignite_new1
emboar_old2 -> emboar_newr
emboar_old -> emboar_news
watchog_old -> watchog_new
whimsicott_old -> whimsicott_new
cottonee_old -> cottonee_new
tympole_old -> tympole_new
palpitoad_old -> palpitoad_new

drilbur_old -> drilbur_new
gigalith_old -> gigalith_new
boldore_old -> boldore_new
pidove_old -> pidove_new
musharna2_old -> musharna_new2
musharna1_old -> musharna_new1
munna_old -> munna_new
panpour_old -> panpour_new
pansear_old -> pansear_new
pansage_old -> pansage_new
liepard_old -> liepard_new
purrloin_old -> purrloin_new
herier_old -> herdier_new

Issue(s) that this PR fixes

Partially #5135

@hedara90 hedara90 added category: pokemon Pertains to Pokémon data and functionality category: overworld Pertains to out-of-battle mechanics labels Nov 15, 2024
Copy link
Collaborator

@hedara90 hedara90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing fixes, everything looks good.
Just one comment not related to your fixes, if you think it's good.

graphics/pokemon/purrloin/overworld.png Show resolved Hide resolved
@Cafeei
Copy link
Author

Cafeei commented Nov 15, 2024

Extended violet markings on south, added missing cream-colored markings above eyes and switched both cream colors on its shiny because they were swapped for some goddamn reason
image image

@hedara90 hedara90 merged commit 8f137b3 into rh-hideout:master Nov 17, 2024
1 check passed
@Cafeei Cafeei deleted the followers-fixes branch November 17, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: overworld Pertains to out-of-battle mechanics category: pokemon Pertains to Pokémon data and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants