Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong Id when AI chooses mon to switch in #5684

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

AlexOn1ine
Copy link
Collaborator

Description

Fixes regression caused by #5435. A wrong id was assigned to gBattleStruct->monToSwitchIntoId in OpponentHandleChoosePokemon which didn't manifest in expansion but for iriv a bad egg switched in.

@AlexOn1ine AlexOn1ine added category: battle-mechanic Pertains to battle mechanics bugfix Bugfixes labels Nov 18, 2024
@Pawkkie Pawkkie self-assigned this Nov 18, 2024
@Pawkkie
Copy link
Collaborator

Pawkkie commented Nov 18, 2024

Yeah this reads so much cleaner I'll merge when CI + iriv test is done :)

Copy link
Collaborator

@Pawkkie Pawkkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed on @iriv24's repo that this also fixed his issue :)

@Pawkkie Pawkkie merged commit 70ca506 into rh-hideout:upcoming Nov 18, 2024
1 check passed
@AlexOn1ine AlexOn1ine deleted the modIdFix branch November 21, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants