Changes taget bit of Flower Shield #5698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
added
category: battle-mechanic
Pawkkie
approved these changes
Nov 23, 2024
iriv24
pushed a commit
to iriv24/pokeemerald-expansion
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MOVE_TARGET_ALL_BATTLERScan't be applied to status moves since they handle the targeting through their own script. This is not ideal because it isn't trivial to make status moves that apply to all battlers but would need a refactor first.This PR replaces the target bit with
MOVE_TARGET_USER. It didn't manifest in expansion but caused a bug in the simultaneous hp reduction branch.