Fixes heal blocked leeach seed in tests #5700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
added
category: battle-mechanic
mrgriffin
previously approved these changes
Nov 21, 2024
| OPPONENT(SPECIES_SHELLDER); | ||
| } WHEN { | ||
| TURN { MOVE(player, MOVE_LEECH_SEED); } | ||
| TURN {} |
There was a problem hiding this comment.
Do you need this second turn?
There was a problem hiding this comment.
not really but I followed the name of the test that was already present as a todo and thought I'll add it
There was a problem hiding this comment.
Happy to merge it as-is, but I thiiink unless I'm misreading the test that it would pass with just the first TURN :)
There was a problem hiding this comment.
oops, right. will adjust
There was a problem hiding this comment.
fixed I think. I compare the drained damage only once though. The other is just a normal hp check. I think this should be enough
|
fixed unrelated failing tests. |
mrgriffin
approved these changes
Nov 21, 2024
iriv24
pushed a commit
to iriv24/pokeemerald-expansion
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test system couldn't recognize that heal block blocked leech seed recovery because the script still ran through all the update hp checks with recovery being set to 0 (I would consider this a bug even).