Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Battle configs during tests #5803

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

AsparagusEduardo
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo commented Dec 12, 2024

Description

Very early implementation of switching gen configs mid-testing.
I recommend giving comments on implementation now before I start it to other configs.

Images

image

Feature(s) this PR does NOT handle:

Right now, it theorically only handles Generational configs, but would be good if it could handle other types of configs.

Discord contact info

AsparagusEduardo

@AsparagusEduardo AsparagusEduardo marked this pull request as draft December 12, 2024 22:54
@AsparagusEduardo AsparagusEduardo changed the base branch from master to upcoming December 15, 2024 20:43
@AsparagusEduardo AsparagusEduardo changed the title [WIP] Setting Battle configs during tests Setting Battle configs during tests Dec 15, 2024
@AsparagusEduardo AsparagusEduardo marked this pull request as ready for review December 15, 2024 22:20
@AsparagusEduardo AsparagusEduardo changed the base branch from upcoming to master December 15, 2024 22:22
@AsparagusEduardo
Copy link
Collaborator Author

Ready for review :)

include/global.h Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need that anymore, that's on me for not cleaning up properly :P

@hedara90 hedara90 added the category: battle-tests Related to the automated test environment label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: battle-tests Related to the automated test environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants