Fixes Quash-affected battlers having the wrong order for End Turn effects #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
reviewed
Dec 20, 2024
AlexOn1ine
added
category: battle-mechanic
AlexOn1ine
approved these changes
Dec 20, 2024
iriv24
pushed a commit
to iriv24/pokeemerald-expansion
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how the previous implementation of Quash set the quash affected battler's act order equal to its position and how it didn't swap any battlers' actions, this caused quash affected battlers to have their end of turn effects happen in an order equal to their positions (playerLeft would always be first, playerRight would always be third, etc.) and if users decide to have certain effects not trigger due to having performed a certain action during a turn, these also took into account the wrong battler's action.
See #5400 for more information on these issues and about the previous implementation of Quash.
Also fixes Ally Switch not swapping battlers actions (likely irrelevant since partner likely already acted if its action does not match)
Discord contact info
PhallenTree