Ensuring check the actual new pod got migrated #44
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyskapunk
reviewed
Jan 2, 2024
|
CC @betoredhat , this is the change I was commenting in the daily jobs regarding the example-cnf issue, @nsilla is off till Monday |
In order to test the pod migration when the current node is cordoned, we get the list of running pods and cordon the node for the first pod in the list. Once the pod is migrated, we get the new list and verify the node for the first pod has changed. The problem is the first pod in the new list is not necessarily the new pod and, even more, it may be more than one pod were running on the cordoned node which may lead us to think the node was not migrated. With this change, we ensure we check the node for the new (migrated) pod in the replica set.
nsilla
force-pushed
the
testpmd_pod_delete
branch
from
20bd4d4
to
ea41fd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to test the pod migration when the current node is cordoned, we get the list of running pods and cordon the node for the first pod in the list.
Once the pod is migrated, we get the new list and verify the node for the first pod has changed.
The problem is the first pod in the new list is not necessarily the new pod and, even more, it may be more than one pod were running on the cordoned node which may lead us to think the node was not migrated.
With this change, we ensure we check the node for the new (migrated) pod in the replica set.