Try to wrap Engine compile function #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
force-pushed
the
engine-compile
branch
from
ddfbc66 to
65d9d8e
Compare
native/rhai_rustler/src/ast.rs
Outdated
| use rhai::AST; | ||
|
|
||
| pub struct ASTResource { | ||
| pub ast: Mutex<AST>, |
There was a problem hiding this comment.
probably for AST is worth using RwLock instead, let's keep this on the radar
test/rhai/engine_test.exs
Outdated
| test "should not compile an invalid expression" do | ||
| engine = Engine.new() | ||
|
|
||
| assert {:error, {:parsing, "parsing error"}} |
There was a problem hiding this comment.
missing = Engine.compile(engine, "$#!")
dottorblaster
force-pushed
the
engine-compile
branch
from
bdecd86 to
febdfa5
Compare
fabriziosestito
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As above, I'm trying to just wrap
engine.compile().