Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properly gated extern "C" to public headers #205

Closed
tedbrandston opened this issue Jan 27, 2022 · 1 comment · Fixed by #207
Closed

Add properly gated extern "C" to public headers #205

tedbrandston opened this issue Jan 27, 2022 · 1 comment · Fixed by #207

Comments

@tedbrandston
Copy link
Contributor

I'd like to add this so that consumers don't need to worry about it.

From #161 I gather that a PR that does this would be welcome. I think it should be sufficient to add something like the following to each of the headers:

#ifdef __cplusplus
extern "C" {
#endif

Just logging my intent to open a PR soon.

@tedbrandston
Copy link
Contributor Author

Waiting on some local testing, but current code is here: tedbrandston@2190005

I'm leaving /* __cplusplus */ comments off of the endifs, because it looks like those are only used for endifs far from their condition.

So far I've tested that make and make test work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant