Add extern "C" to headers for easier use by C++
#207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `extern "C"` directly to all headers except efivar-guids.h, which is generated. Because it interferes with C compilers, wrap each `extern` in an `#ifdef __cplusplus`. For efivar-guids.h update the generator, makeguids.c, to add the desired code. From https://en.cppreference.com/w/cpp/language/language_linkage: > extern "C" makes it possible to include header files containing > declarations of C library functions in a C++ program, but if the > same header file is shared with a C program, extern "C" (which > is not allowed in C) must be hidden with an appropriate #ifdef, > typically __cplusplus. Signed-off-by: Ted Brandston <tbrandston@google.com>
tedbrandston
force-pushed
the
extern-c
branch
from
da0bb82
to
28789d1
Compare
frozencemetery
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
extern "C"directly to all headers except efivar-guids.h, whichis generated. Because it interferes with C compilers, wrap each
externin an#ifdef __cplusplus. For efivar-guids.h update thegenerator, makeguids.c, to add the desired code.
From https://en.cppreference.com/w/cpp/language/language_linkage:
fixes #205
Tests:
makeandmake testboth workextern "C"removed from my code.