Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add efi_time_t declarations and helper functions. #183

Merged
merged 3 commits into from
Nov 11, 2021

Conversation

vathpela
Copy link
Contributor

@vathpela vathpela commented Nov 9, 2021

Note that this is layered on top of #182

Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Other PR's commit review in other PR.)

All comments inline. Happy to clean up line lengths etc. during merging if that's easier.

src/list.h Outdated Show resolved Hide resolved
src/include/efivar/efivar-time.h Outdated Show resolved Hide resolved
src/include/efivar/efivar-time.h Outdated Show resolved Hide resolved
src/include/efivar/efivar-types.h Outdated Show resolved Hide resolved
src/time.c Outdated Show resolved Hide resolved
src/time.c Show resolved Hide resolved
Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three questions inline. If the answers are all "yes that's fine", then this looks good to me.

src/compiler.h Outdated Show resolved Hide resolved
src/list.h Show resolved Hide resolved
src/list.h Outdated Show resolved Hide resolved
This just splits out some of the stuff that didn't really belong in
util.h .

Signed-off-by: Peter Jones <pjones@redhat.com>
Again, just moving stuff around to slightly more consumable locations.

Signed-off-by: Peter Jones <pjones@redhat.com>
This adds the hilariously defective efi_time_t type, as well as
conversion utilities to and from it, and utilities for formatted output
of it.

Optionally, for compatibility with older source trees, if your
application defines EFIVAR_NO_EFI_TIME_T to any value other than 0, it
will *not* do so, though that option may go away in some future efivar
version.  This allows you to turn off declaration of efi_time_t and
related functions in the case where it's declared someplace else, such
as in some local code or another library's headers.

Signed-off-by: Peter Jones <pjones@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants