Coverity fixes 20211208 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once again, coverity fails to actually build anything with certain versions of gcc: - it looks like the _Float128 definitions might actually not cause a problem now! - But _Mdouble_Complex_ does - And so do the __malloc__ attributes that use arguments This attempts to work around these problems, none of which should actually affect operation of any code, when coverity is in use. Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Coverity spotted that in this one case of print_dev_dp_node() we don't handle the return value from efidp_make_end_entire(). Signed-off-by: Peter Jones <pjones@redhat.com> [rharwood@redhat.com: commit message tweaks] Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Coverity has correctly noted that despite its name, efidp_infiniband.ioc_guid is not in fact a GUID, and can't be printed like one. This gets rid of the extra code. I'm still not sure we're printing it correctly, but until someone notices that we're not, that's probably fine. Signed-off-by: Peter Jones <pjones@redhat.com>
frozencemetery
force-pushed
the
coverity-fixes-20211208
branch
from
1b4d531
to
c745bb5
Compare
frozencemetery
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pile of minor fixes for stuff coverity and scan-build found that aren't related to PR 184.