Adjust dependency for libefivar and libefiboot objects #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not a maintainer, but I can reproduce the issue and confirm that this PR fixes it. |
frozencemetery
approved these changes
Jun 8, 2022
Depending on 'prep' causes all objects to be rebuilt every time 'make' is invoked. Depending on '$(GENERATED_SOURCES)' causes a build failure because guid-symbols.c gets passed to the compiler due to a rule in rules.mk. Depend on 'include/efivar/efivar-guids.h' directly to avoid these issues. Fixes: rhboot#199 Signed-off-by: Mike Gilbert <floppym@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on 'prep' causes all objects to be rebuilt every time 'make'
is invoked.
Depending on '$(GENERATED_SOURCES)' causes a build failure because
guid-symbols.c gets passed to the compiler due to a rule in rules.mk.
Depend on 'include/efivar/efivar-guids.h' directly to avoid these
issues.
Fixes: #199
Signed-off-by: Mike Gilbert floppym@gentoo.org