Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use off_t instead of off64_t #237

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Use off_t instead of off64_t #237

merged 1 commit into from
Feb 6, 2023

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Dec 15, 2022

Pass _FILE_OFFSET_BITS=64 to ensure 64bit off_t

Signed-off-by: Khem Raj raj.khem@gmail.com

frozencemetery
frozencemetery requested changes Dec 15, 2022
View reviewed changes
Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in efivar.

Looking at this change and commit, it's not immediately obvious why this change is being proposed. The commit message is missing motivation (the "why") for this change.

@kraj
Use off_t instead of off64_t
356e969 
Pass _FILE_OFFSET_BITS=64 to ensure 64bit off_t

This helps building efivar for 32bit arches on systems using musl C
library. It works with glibc since _GNU_SOURCE defines
_LARGEFILE64_SOURCE as well, this feature test macro enables the 64bit
interfaces which were done as intermediate steps when transition to
66-bit off_t was done as part olf LFS64 support.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
@kraj
Copy link
Contributor Author

kraj commented Dec 15, 2022

Thanks for your interest in efivar.

Looking at this change and commit, it's not immediately obvious why this change is being proposed. The commit message is missing motivation (the "why") for this change.

yeah, fair point. I have tried to improve the commit message in v2.

@frozencemetery frozencemetery merged commit 914c686 into rhboot:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozencemetery frozencemetery frozencemetery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kraj @frozencemetery