linux: handle non-ACPI systems in device_get() #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/sys/devices/pci0000:00/firmware_node/hid does not exist on all systems. Kernel parameter acpi=off has been reported as one possible reason in rhboot#120 But this is not the only case. On systems using device trees you may also not find this file. We have multiple parsers in dev_probes[]. It is sufficient that one of these parsers succeeds to provide the device information. If for instance pci_root_parser and pci_parser fails, we may still get information from nvme_parser. If a parser fails, only write a debug information and continue. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
|
Is there anything blocking this from getting merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/sys/devices/pci0000:00/firmware_node/hid does not exist on all systems. Kernel parameter acpi=off has been reported as one possible reason in #120
But this is not the only case. On systems using device trees you may also not find this file.
We have multiple parsers in dev_probes[]. It is sufficient that one of these parsers succeeds to provide the device information.
If for instance pci_root_parser and pci_parser fails, we may still get information from nvme_parser.
If a parser fails, only write a debug information and continue.