Change set&append data to be const. #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All implementations of set_variable and append_variable never modify the data pointed to. Callers don't know by the function signitures that their data will not be modified nor can they pass const buffers without warnings. This commit adds const to all function signatures and fixes the one assignment where the pointer is copied to a non-const pointer. Signed-off-by: Ed Schaller <schallee@darkmist.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All implementations of set_variable and append_variable never modify the data pointed to. Callers don't know by the function signitures that their data will not be modified nor can they pass const buffers without warnings. This commit adds const to all function signatures and fixes the one assignment where the pointer is copied to a non-const pointer.