Discover unified kernel images on EFI #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osteffenrh
changed the title
osteffenrh
changed the title
osteffenrh
changed the title
|
Reopened and ready for comments. Sorry for the mess 😅 |
osteffenrh
force-pushed
the
uki-2-discover-uki
branch
from
f9e75a3
to
80ff774
Compare
|
Improved os-rel parsing. |
osteffenrh
force-pushed
the
uki-2-discover-uki
branch
from
80ff774
to
ea41258
Compare
|
The Boot Loader Interface patches are now upstream: Any comments on this PR are very welcome. |
osteffenrh
force-pushed
the
uki-2-discover-uki
branch
from
ea41258
to
ca745d9
Compare
vathpela
reviewed
Sep 5, 2023
vathpela
reviewed
Sep 5, 2023
vathpela
requested changes
Sep 5, 2023
osteffenrh
force-pushed
the
uki-2-discover-uki
branch
from
ca745d9
to
3149640
Compare
This avoids compiler warnings in case bls_add_keyval() is called with const char* as arguments. Signed-off-by: Oliver Steffen <osteffen@redhat.com>
Add a new command "blscfg_uki" to the blscfg module. It looks for unified kernel images (UKI) in the locations defined by the Boot Loader Specification. Additionally check on the device indicated by the $root variable. Add all UKIs found to the menu. The UKI are booted using the 'chainloader' command on EFI. Signed-off-by: Oliver Steffen <osteffen@redhat.com>
osteffenrh
force-pushed
the
uki-2-discover-uki
branch
from
3149640
to
a4442fb
Compare
|
@vathpela ping? GitHub still shows one change request as open, although I marked it as resolved. Strange. Rebased and updated PR target branch. |
|
@vathpela ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
blscfgmodule implements the Boot Loader Specification for "Type 1" entries = configuration snippets.This PR extends this module to also handle "Type 2" entries: unified kernel images (UKI) by adding
a new command "blscfg_uki". It searches for UKI in
/EFI/Linuxon the EFI partition and on$root(probably
/boot) and adds them to the menu.