-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NComputing LEAFOS shim-15.8 x64 #401
Comments
Disclaimer: I am not an official reviewer.
|
Hi @aronowski |
I'll give it a try, although it's important to note that I'm already preoccupied with other applications, as well as personal things going on in my life. It's a good thing that there already was an accepted application, making things easier. However, feel free to ping another reviewer if there's no review from me for some time. |
Hello @steve-mcintyre @jsetje @vathpela ! |
Huge thanks to @eduardacatrinei for the review! The build reproduces, checksum matches, characteristics are OK. Contacts have been verified as part of application #279 and haven't changed. The application is very well-written apart from some rendering issues, possibly regarding a different Markdown dialect being used. Accepting! |
Thank You very much! |
Sorry. Probably I need to reopen and then close after signing by MS? |
On 2024.04.15 01:39:28, ncboot wrote:
Sorry. Probably I need to reopen and then close after signing by MS?
While I'm not a Microsoft employee and can't speak on behalf of the company,
leaving the GitHub issue open should help with organizing things here. After
all, we can therefore track these, where people are waiting to receive signed
binaries.
… --
Reply to this email directly or view it on GitHub:
#401 (comment)
You are receiving this because you were assigned.
Message ID: ***@***.***>
|
@ncboot did you get a signed shim back by now? |
Confirm the following are included in your repo, checking each box:
What is the link to your tag in a repo cloned from rhboot/shim-review?
https://github.com/ncboot/shim-review/tree/ncomputing-shim-x64-20240313
What is the SHA256 hash of your final SHIM binary?
[1075d8cee7fac50c87e3b9b10accaed6eaff7514d09122fd7803ece1e3fcbaa0 shimx64.efi]
What is the link to your previous shim review request (if any, otherwise N/A)?
[https://github.com//issues/279]
The text was updated successfully, but these errors were encountered: