Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim 15.8 for UOS Linux (x86_64) #431

Open
8 tasks done
kyrie-z opened this issue Jul 11, 2024 · 15 comments
Open
8 tasks done

Shim 15.8 for UOS Linux (x86_64) #431

kyrie-z opened this issue Jul 11, 2024 · 15 comments
Labels
contact verification pending Contact verification emails have been sent, waiting on response

Comments

@kyrie-z
Copy link

kyrie-z commented Jul 11, 2024

Confirm the following are included in your repo, checking each box:

  • completed README.md file with the necessary information
  • shim.efi to be signed
  • public portion of your certificate(s) embedded in shim (the file passed to VENDOR_CERT_FILE)
  • binaries, for which hashes are added to vendor_db ( if you use vendor_db and have hashes allow-listed )
  • any extra patches to shim via your own git tree or as files
  • any extra patches to grub via your own git tree or as files
  • build logs
  • a Dockerfile to reproduce the build of the provided shim EFI binaries

What is the link to your tag in a repo cloned from rhboot/shim-review?


https://github.com/kyrie-z/shim-review/tree/uos-shim-15.8-amd64-20240711
https://github.com/kyrie-z/shim-review/tree/uos-shim-15.8-amd64-20240806


What is the SHA256 hash of your final SHIM binary?


958987f06da4438ab43a873e2c0dd65478299b284ad6e53ca2528524e3a069dd shimx64.efi


What is the link to your previous shim review request (if any, otherwise N/A)?


[UOS shim 15.4 for x86_64 #173 ]


If no security contacts have changed since verification, what is the link to your request, where they've been verified (if any, otherwise N/A)?


N/A

@steve-mcintyre steve-mcintyre added contact verification needed Contact verification is needed for this review contact verification pending Contact verification emails have been sent, waiting on response and removed contact verification needed Contact verification is needed for this review labels Jul 15, 2024
@steve-mcintyre
Copy link
Collaborator

verification emails sent

@kyrie-z
Copy link
Author

kyrie-z commented Jul 19, 2024

@steve-mcintyre Sorry for the late reply, but I want to confirm what went wrong. I did not receive the verification email about "shim review". The contact email is zhouzilong@uniontech.com.
Please confirm again whether it has been sent. Thanks!

@kyrie-z kyrie-z closed this as completed Jul 19, 2024
@kyrie-z kyrie-z reopened this Jul 19, 2024
@jclab-joseph
Copy link

jclab-joseph commented Jul 30, 2024

Review of reproducibility for uos-shim-15.8-amd64-20240711

review helper : https://github.com/jclab-joseph/other-shim-reviews/tree/master/20240730-uos-shim-15.8-amd64-20240711

shim

certificate

  • Not After: Jan 16 00:00:00 2054 GMT
  • 4096 bit cert and valid for almost 30 years
  • The key is kept in a red zone room with strict physical and network isolation mechanisms. Compliant with FIPS 140-2 Level 2 security standards

grub

  • debian's 2.06-3~deb10u4
  • ntfs module is included, sbat is grub,4.

@steve-mcintyre
Copy link
Collaborator

Re-sent verification mails to

@steve-mcintyre
Copy link
Collaborator

And also sending to zhouzilong@uniontech.com

Not sure where I found the yanbowen mail - maybe an older review. Sorry.

@kyrie-z
Copy link
Author

kyrie-z commented Jul 31, 2024

Contact verification for zhouzilong@uniontech.com:

gages schoolboy raving preview diagramming holds results cicatrix linger sulphuring

@steve-mcintyre
Copy link
Collaborator

Just waiting on the response from lichenggang@uniontech.com now.

@Zeno-sole
Copy link

Just waiting on the response from lichenggang@uniontech.com now.

The old key has expired. Can I use a new key?
new key:https://github.com/kyrie-z/shim-review/blob/uos-shim-15.8-amd64-20240711/key/ChenggangLi.pub

@steve-mcintyre
Copy link
Collaborator

Just waiting on the response from lichenggang@uniontech.com now.

The old key has expired. Can I use a new key? new key:https://github.com/kyrie-z/shim-review/blob/uos-shim-15.8-amd64-20240711/key/ChenggangLi.pub

The mail I sent was encrypted to this key, which does not appear to have expired:

pub   rsa3072/B4EE92960BB8C880 2021-04-23 [SC]
      B711456DD79BDCA3100EE9B6B4EE92960BB8C880
uid                 [ unknown] lichenggang <lichenggang@uniontech.com>
sub   rsa3072/66A6A001ED9D8D69 2021-04-23 [E]

The new key you're suggesting I use does not match the email address lichenggang@uniontech.com:

pub   rsa4096/A757694FF3D0B626 2024-07-11 [SC]
      61AE69171770E71B39D842F1A757694FF3D0B626
uid                 [ unknown] lichenggang <lichenggang@deepin.org>
sub   rsa4096/0EC1F8845EC8DD6B 2024-07-11 [E]

Please fix this.

Could you also please explain for us: what is the relationship between:

  • UnionTech Software Technology (uniontech.com)
  • UOS (chinauos.com)
  • Deepin (deepin.org)

Some consistency in UIDs and keys here is necessary.

@kyrie-z
Copy link
Author

kyrie-z commented Aug 2, 2024

Could you also please explain for us: what is the relationship between:

  • UnionTech Software Technology (uniontech.com)
  • UOS (chinauos.com)
  • Deepin (deepin.org)

I apologize for any confusion regarding the names. Please allow me to clarify:
Deepin Technology Co., Ltd. ("Deepin Technology") is a wholly-owned subsidiary of UnionTech Software Technology Co., Ltd. ("UnionTech Software").
Deepin Technology owns the product "deepin" (product website: https://www.deepin.org/), while UnionTech Software owns the product "UOS" (product website: https://www.chinauos.com/).

@kyrie-z
Copy link
Author

kyrie-z commented Aug 2, 2024

@steve-mcintyre I have updated the secondary contact email address to keep the email address consistent with the UID. Please use the new key for contact verification. Looking forward to hearing from you, thanks!
https://github.com/kyrie-z/shim-review/blob/uos-shim-15.8-amd64-20240711/README.md#who-is-the-secondary-contact-for-security-updates-etc

@steve-mcintyre
Copy link
Collaborator

Mail on the way. As you've updated your submission in git, please also add a new tag and update the issue here with that new tag.

@kyrie-z
Copy link
Author

kyrie-z commented Aug 6, 2024

I have created a new tag and updated the issue.
New tag: https://github.com/kyrie-z/shim-review/tree/uos-shim-15.8-amd64-20240806

@kyrie-z
Copy link
Author

kyrie-z commented Aug 6, 2024

By the way, the tags uos-shim-15.8-amd64-20240711 and uos-shim-15.8-amd64-20240806 are associated with the same commit (kyrie-z/shim-review@02e5eb2). I believe that jclab-joseph's review #431 (comment) is very useful, so I'm mentioning this to avoid duplicate review efforts.
I hope this helps with your review. Thank you.

@Zeno-sole
Copy link

Contact verification for lichenggang@deepin.org:

puritan segregate expatriating Alnitak homily daffodils Avalon bountiful blurted Hecuba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contact verification pending Contact verification emails have been sent, waiting on response
Projects
None yet
Development

No branches or pull requests

4 participants