Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load shim_certificates.efi during netboot #665

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rosslagerwall
Copy link

Network boot cases do not support reading through a directory but it can still be useful to load unbundled certificates. Try to load them directly.

Network boot cases do not support reading through a directory but it can still
be useful to load unbundled certificates. Try to load them directly.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
@jsetje
Copy link
Collaborator

jsetje commented Jun 17, 2024

The naming convention for those files is supposed to be "shim_certificate*.efi", but obviously that won't work without some sort of a readdir. Do you want to support a single, different filename for netboot? (Edit: this may well make sense, I just want to make sure it's intentional.)

Also, that will generate another line of noise when it's not there. I should probably just break up the interface to properly suppress that message. (I didn't want to risk that at the time when I created the initial netboot revocations.efi changes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants