Fix SBAT.md for today's consensus about numbers #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per rhboot#634, the current consensus seems to be for generation numbers to only ever go up and not get reset. This has been clarified and an example related to this behavior has been described. Signed-off-by: Kamil Aronowski <kamil.aronowski@yahoo.com>
SBAT.md
Outdated
Comment on lines
245
to
248
| In the perfect scenario, to provide the perfect security, the UEFI SBAT | ||
| revocation variable (named *SbatLevel*) would then be set, so that GRUB with a | ||
| global generation number of only 4 or higher would be able to be booted. (In | ||
| reality there's naturally going to be a certain grace period) |
There was a problem hiding this comment.
I don't think you need to emphasise the "perfect security" etc. so much here. Maybe just:
After this, the UEFI SBAT revocation variable (named SbatLevel) would be updated to raise the minimum global generation number for GRUB to 4.
?
There was a problem hiding this comment.
How about "[...] to raise the mandatory minimal global generation number [...]", putting an emphasis on the "must" in "from this point in time it must be 4 or higher"?
Signed-off-by: Kamil Aronowski <kamil.aronowski@yahoo.com>
steve-mcintyre
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #634, the current consensus seems to be for generation numbers to only ever go up and not get reset. This has been clarified and an example related to this behavior has been described.