Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetUpCdromSourceTask: Allow setup source to all mountable partitions #3599

Closed
wants to merge 1 commit into from

Conversation

slayercat
Copy link

see also: #3594

@pep8speaks
Copy link

pep8speaks commented Sep 9, 2021

Hello @slayercat! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-09-12 10:15:28 UTC

@slayercat
Copy link
Author

slayercat commented Sep 9, 2021

As discuss in #3594 , we made some code to prove our idea.

This patch has been tested offline with CentOS-Stream-8-aarch64-20210902-dvd1. (basicly)

With make an efi (FAT32) partition, and copies all files in the ISO file to it, It'll boot and install in a aarch64 machine.

You may want to review these log files:

tmp.zip

@jkonecny12
Copy link
Member

Hi thanks for the PR, however, switching CDRom source from Optical Media to mountable device would change behavior of the CDRom source. In that case we could discover completely different sources for inst.cdrom. For this reason we should instead follow solution that we would add a new source which would re-use existing mount from a Dracut. However, even in that case we had to make sure that this do not break some use-cases.

@slayercat slayercat force-pushed the dev-setup-from-hd branch 2 times, most recently from 9e7f043 to 63b2b30 Compare September 12, 2021 09:54
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jan 6, 2022
@jkonecny12
Copy link
Member

Just now I'm working on a alternative solution to this. Hopefully, I'll be able to create the PR soon. Closing this PR for now.

@jkonecny12 jkonecny12 closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants