-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpm-ostree: Setup readonly sysroot for ostree & rw karg #4240
Conversation
Updated to try to fix unit tests. |
/kickstart-test --testtype smoke |
The failures here do not seem to be related to this PR. |
I'm sorry for the late PR. I'd like to get this one into F37. Let me know how I can help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks good. We usually change tests in the same commit as code, otherwise I don't see anything that could need changing.
For getting this into 37, that should be no problem.
Thanks! I've merged the commits into a single one. |
One thing I'm wondering here is about Fedora IoT. Is IoT using Anaconda for installations? Does it want to opt-out of this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Thanks for solving this problematic issue @travier !
/kickstart-test --testtype smoke |
@travier, can you please change the commit message bug link to:
|
- Enable read only sysroot in the ostree repo config. - Add `rw` to the kernel arguments to keep statefull parts of the system (/var & /etc) writable. - Update units tests to account for the new rw karg See: https://fedoraproject.org/wiki/Changes/Silverblue_Kinoite_readonly_sysroot Resolves: rhbz#2086489
Updated. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, perfect!
/kickstart-test --testtype smoke |
Manually tested:
Everything seems to be working just as expected. |
@travier this PR is ready to be merged but I guess we are waiting for @nullr0ute reaction? |
Yes, I'd prefer we get an ack from him before we merge. Can you also check that the content of
Thanks! |
Correct:
|
Hi @travier I would like to get this merge rather sooner than later. Do we want to wait for @nullr0ute or maybe we can ask someone else? |
Yes, we do use the anaconda installer (and in RHEL for Edge) |
Apologies for the late reply, got lost in my inbox, it's been a busy week. |
Hi @nullr0ute, thanks for reply but the main question is if you want to be opted-out from this change or you agree to have |
Agreed, we do not want to opt out, the more RO the better :) |
Great! I'll add IoT in the Fedora change description and to the Fedora release notes. |
In that case I'm merging this now. Thanks @travier and @nullr0ute for your input. |
rw
to the kernel arguments to keep statefull parts of the system(/var & /etc) writable.
See: https://fedoraproject.org/wiki/Changes/Silverblue_Kinoite_readonly_sysroot
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2086489