🐛 - Gitlab LDAP bindDN and base not fully qualified

[eformat]

when deploying the base tl500 helm chart - the ldap creds for gitlab are automatically created by looking up the OAuth identity provider

this is done in the _helpers.tpl code

BUT .. we just had an instance where the "bind_dn" and "base" in the GITLAB_OMNIBUS_CONFIG was set wrong ! here are the screenshots:

They should be:

'bind_dn' => 'uid=ldap-sa,cn=users,cn=accounts,dc=rht-labs,dc=com',
'base' => 'cn=accounts,dc=rht-labs,dc=com'

So, the lookup is failing somehow.

I have noticed similar behavior in another chart where you NEED to escape the ',' e.g.

helm upgrade --install my-chart \
--set ldap_bind_dn="uid=ldap_admin\\,cn=users\\,cn=accounts\\,dc=redhatlabs\\,dc=dev"

Anyway .. this needs looking into root cause. It doesn't happen in every deployment, this is the first i have seen it in the real !

[jfilipcz]

Root cause was simple - since I've started to works with those helm-charts, we had some issues with gitlab integration (with configuration set through the helper), and resorted back to using values set manually:)

[jfilipcz]

I will give it another test on my private cluster, and if all works out we can close the issue (possibly with a documentation update)

[jfilipcz]

Tests confirmed all is working fine.

[eformat]

@jfilipcz thanks for confirming ! OK .. yeah \, escaping needed :) if setting values for ldap

the lookup logic works fine though, has not broken ever as far as i can tell