Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab Readme and default password update #119

Merged

Conversation

jfilipcz
Copy link
Contributor

  • Updated README to cover Gitlab integration with LDAP
  • Updated root password for Gitlab;)

@jfilipcz jfilipcz requested a review from eformat May 19, 2022 11:52
@jfilipcz jfilipcz self-assigned this May 19, 2022
@jfilipcz jfilipcz linked an issue May 19, 2022 that may be closed by this pull request
* Updated root password for Gitlab;)
Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @jfilipcz
I've requested two minor changes.

tooling/README.md Outdated Show resolved Hide resolved
tooling/charts/tl500-base/values.yaml Show resolved Hide resolved
Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pabrahamsson pabrahamsson merged commit ccdbd1d into rht-labs:main May 19, 2022
@eformat
Copy link
Member

eformat commented May 19, 2022

@pabrahamsson @jfilipcz - there is NO valid reason to change the default password ?
security through obscurity never works.
Pass this parameter to the chart when installing if you dont want the defaults !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 - Gitlab LDAP bindDN and base not fully qualified
3 participants