Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for CI #289

Merged
merged 16 commits into from
Aug 23, 2019
Merged

Fix CI for CI #289

merged 16 commits into from
Aug 23, 2019

Conversation

pcarney8
Copy link
Contributor

@pcarney8 pcarney8 commented Aug 14, 2019

Fixes #286

Fixing pact-broker

Pinning sonarqube to 7.7 to close #283

#282 is also fixed because of the updates to s2i-config-jenkins repo and pointing to a new version

pabrahamsson
pabrahamsson previously approved these changes Aug 14, 2019
Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcarney8 pcarney8 changed the title Fix pact broker Fix CI for CI Aug 15, 2019
…ric sonarqube build to include imagestream from my fork (will update later)
Copy link
Member

@jacobsee jacobsee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything is running happily.

Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oybed oybed merged commit 6f76b69 into rht-labs:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI for labs-ci-cd is broken Pin SonarQube to version 7.7 For K8s/OpenShift Compatibility
4 participants