Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt.getAttemptNumber can return int instead of long #27

Closed
rhuffman opened this issue Dec 23, 2017 · 1 comment
Closed

Attempt.getAttemptNumber can return int instead of long #27

rhuffman opened this issue Dec 23, 2017 · 1 comment
Labels
fixed

Comments

@rhuffman
Copy link
Owner

It makes little sense to have the Retryer retry more than Integer.MAX_VALUE times, and, in fact, the Retryer uses an int variable to iterate. Therefore, the attempt number can be an int.
rhuffman added a commit that referenced this issue Dec 31, 2017
@rhuffman
Refactor Retryer
fef672f 
== DETAILS

Attempting to make the call method a little cleaner.

Also change the attempt number in Attempt from long to int, resolving
issue #27.
@rhuffman
Copy link
Owner Author

Merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhuffman