avoid crash on inline HTML inside blockquote

rhysd · Sep 23, 2024 · ebc4964 · ebc4964
1 parent 7772303
commit ebc4964
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 2 deletions.
diff --git a/v2/fuzz/fuzz_targets/parse_markdown.rs b/v2/fuzz/fuzz_targets/parse_markdown.rs
@@ -11,6 +11,7 @@ fuzz_target!(|data: &[u8]| {
     else {
         return;
     };
+    dbg!(&source);
     let target = MarkdownContent::new(source, None);
     let parser = MarkdownParser::new(&target, offset, ());
     let mut buf = Vec::new();

diff --git a/v2/src/markdown/parser.rs b/v2/src/markdown/parser.rs
@@ -762,8 +762,12 @@ impl<'input, W: Write, V: TextVisitor, T: TextTokenizer> RenderTreeEncoder<'inpu
                     self.text(&text, inner_range)?;
                     self.tag_end()?;
                 }
-                Event::Html(_) => unreachable!(), // This event is handled in `Tag::HtmlBlock` event using `HtmlBlockReader`
-                Event::InlineHtml(html) => {
+                // Inline HTML inside blockquote is emitted as Event::Html event wrongly. Uncomment the below line when
+                // the following issue is fixed and the fix is released.
+                // https://github.com/pulldown-cmark/pulldown-cmark/issues/960
+                //
+                // Event::Html(_) => unreachable!(), // This event is handled in `Tag::HtmlBlock` event using `HtmlBlockReader`
+                Event::Html(html) | Event::InlineHtml(html) => {
                     self.tag("html")?;
                     self.out.write_all(br#","raw":""#)?;
 
@@ -1053,6 +1057,7 @@ mod tests {
     snapshot_test!(escaped_chars_in_text);
     snapshot_test!(alert);
     snapshot_test!(url_inside_link);
+    snapshot_test!(inline_html_inside_blockquote);
 
     // Offset
     snapshot_test!(offset_block, Some(30));

diff --git a/...down/snapshots/shiba_preview__markdown__parser__tests__inline_html_inside_blockquote.snap b/...down/snapshots/shiba_preview__markdown__parser__tests__inline_html_inside_blockquote.snap
diff --git a/v2/src/markdown/testdata/inline_html_inside_blockquote.md b/v2/src/markdown/testdata/inline_html_inside_blockquote.md