fix: fix activity types of the event watch
#334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The activity type `starred` is wrong. The correct activity type is `started`. - github/docs#27127 - github/docs#27129
|
@suzuki-shunsuke Thank you for catching it and fixing the upstream. The upstream change was automatically imported at #335 along with other changes in action inputs. But I'll merge this PR for crediting you. |
rhysd
approved these changes
Aug 5, 2023
|
Oh, I'm sorry that I missed the document. 🙇♂️ https://github.com/rhysd/actionlint/blob/main/CONTRIBUTING.md#maintain-all_webhooksgo Thank you for merging this pull request. |
|
@rhysd I'm sorry to bother you, but do you have any plan to release a new version? |
Closed
|
I created an issue. #351 |
|
@suzuki-shunsuke Would you check #351? I'll try to do it by this weekend. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The activity type
starredis wrong.The correct activity type is
started.https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#watch
GitHub's official document was wrong, so I fixed it.
starredgithub/docs#27127watchevent's activity typestarredis wrong. The correct activity type isstartedgithub/docs#27129