Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add -e flag when vimpath is vim.exe #3

Merged
merged 1 commit into from
Dec 6, 2022
Merged

add -e flag when vimpath is vim.exe #3

merged 1 commit into from
Dec 6, 2022

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Dec 6, 2022

If -vimpath vim is set, vim.exe never quit. Probably, vim.exe does not safe for closed stdout.

rhysd
rhysd approved these changes Dec 6, 2022
View reviewed changes
Copy link
Owner

@rhysd rhysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

@rhysd rhysd merged commit 3ab4578 into rhysd:master Dec 6, 2022
@rhysd
Copy link
Owner

rhysd commented Dec 6, 2022

v1.3.1 shipped this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhysd rhysd rhysd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattn @rhysd