Test allowing g: omitted function names and rejecting global g: omitt…

…ed variables - Added g: omitted function names as invalid case
rhysd · Nov 28, 2015 · 97d024d · 97d024d
1 parent f5acb44
commit 97d024d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/test/fixture/policy/prohibit_implicit_scope_variable_invalid.vim b/test/fixture/policy/prohibit_implicit_scope_variable_invalid.vim
@@ -17,3 +17,7 @@ function! autoload#ImplicitGlobalAutoloadFunc(param)
     echo autoload#AnotherImplicitGlobalAutoloadFunc(param)
 endfunction
 call autoload#ImplicitGlobalAutoloadFunc(1)
+
+" implicit global variable 'i'
+for i in [1, 2, 3]
+endfor
diff --git a/test/fixture/policy/prohibit_implicit_scope_variable_valid.vim b/test/fixture/policy/prohibit_implicit_scope_variable_valid.vim
@@ -60,3 +60,12 @@ echo b:
 echo w:
 echo t:
 echo v:
+
+" Allow to omit g: from function names (#136)
+function! ImplicitGlobalFunc()
+endfunction
+call ImplicitGlobalFunc()
+
+function! autoload#ImplicitGlobalAutoloadFunc()
+endfunction
+call autoload#ImplicitGlobalAutoloadFunc()
diff --git a/test/integration/vint/linting/policy/test_prohibit_implicit_scope_variable.py b/test/integration/vint/linting/policy/test_prohibit_implicit_scope_variable.py
@@ -33,6 +33,7 @@ def test_get_violation_if_found_when_file_is_invalid(self):
             self.create_violation(8, 5),
             self.create_violation(12, 10),
             self.create_violation(17, 53),
+            self.create_violation(22, 5),
         ]
 
         self.assertFoundViolationsEqual(PATH_INVALID_VIM_SCRIPT,
@@ -47,6 +48,7 @@ def test_get_violation_if_found_when_autoloads_are_suppressed(self):
             self.create_violation(8, 5),
             self.create_violation(12, 10),
             self.create_violation(17, 53),
+            self.create_violation(22, 5),
         ]
 
         self.assertFoundViolationsEqual(PATH_INVALID_VIM_SCRIPT,