Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DestinationFolder Parameter to specify the destination folder on A... #2

Closed
wants to merge 2 commits into from

Conversation

stephenwelsh
Copy link

Just a minor addition to simplify to selection of the upload destination folder

rhysgodfrey added a commit that referenced this pull request Jun 23, 2014
@rhysgodfrey
Copy link
Owner

Thank you for the PR and updating the library 👍 Sorry it took so long to close, I haven't checked this repo for a while. I've merged the changes in, unfortunately couldn't automatically merge from the pull request, and so had to merge manually, think I may have made a mess of this, and the commit is now against my user.

I've added a thanks to the README, if you want the commit correctly assigned to you sure we can figure something out (think the manually merge can be reverted, then merge into your copy and resubmit the PR).

Thanks again for your help, and apologies for the delay and merge issue.

@stephenwelsh
Copy link
Author

Hi Rhys,

No worries, I didn't do it for the credit ;)

I struggle with handling git checkin’s too, fantastic source control, just takes a bit to master ;)

In-fact this project inspired me with a recent requirement to automatically publish release notes to Zendesk when building (we use Team City for our CI), so we now upload to Azure and publish release notes all part of the build process.

I’ve given you access to the private MSBuildZendesk (https://github.com/unifiedfx/MSBuildZendesk) repo, I’m planning to make it public, but I need to get agreement from the other Directors before hand.

As part of using these with our build process I also have plans to include meta-data support in the MSBuildAzure code so I can embed the URL for the release notes against the published MSI file, so our secure download service that sits in-front of the Azure Storage blob (where the compiled project is uploaded too) can also direct users to the release notes for the download by reading the files meta data….

Thanks

Stephen

On 23 Jun 2014, at 23:06, Rhys Godfrey <notifications@git.luolix.topmailto:notifications@github.com> wrote:

Thank you for the PR and updating the library [:+1:] Sorry it took so long to close, I haven't checked this repo for a while. I've merged the changes in, unfortunately couldn't automatically merge from the pull request, and so had to merge manually, think I may have made a mess of this, and the commit is now against my user.

I've added a thanks to the README, if you want the commit correctly assigned to you sure we can figure something out (think the manually merge can be reverted, then merge into your copy and resubmit the PR).

Thanks again for your help, and apologies for the delay and merge issue.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-46908591.

@stephenwelsh
Copy link
Author

I forgot to include, here is a sample of our automatically published release notes:

http://support.unifiedfx.com/entries/73777637-PhoneView-4-1-0-168-Release-Notes

This comes from the releasenotes.txt file we include in our product, it’s formatted as Markdown which is readable enough directly by the end users, but also generates well formatted HTML for the forum post ;)

New Functionality Introducted in PhoneView 4.1

  • New ITL Scanner Edition
  • New ITL/CTL Delete Edition
  • Added full support/testing for CUCM Versions 10.0 & 10.5
  • Added support for the 7821, 7841, 7861 IP phone models
  • Enhancements to Scan performance
  • Simplified Management of ITL issues discovered after a Scan

Download PhoneView 4.1.0.168

New and Changed Information for Version 4.1.0.168

  • Fix RISPort issue - not detecting retry response correctly
  • Included Additional Switch Port Information - Port Speed (SWPortSpeed) to Data View and Export

New and Changed Information for Version 4.1.0.165

  • Changed location of CTI Files to user local folder
  • Re-enable use of Phone Control User when Policy Applied
  • Correct invalid/missing data from Data Export
  • Fix issue with Bulk Actions Policy Feature
  • Fix issue launching PhoneView from a PVD file
  • Automatically start Add Cluster/Simple Setup if no cluster has ever been configured
  • Fixed incorrect export filename Date/Time
  • Apply upper limit on connections per second to TFTP Server
  • Fix issue that prevented HTTP fallback with multiple clusters of different versions

New Functionality Introducted in PhoneView 4.0

  • Policy Controlled Features for Users and Groups
  • Re-Written Queuing Engine for Maximum Performance
  • Highly Optimised CTI Based Remote Control
  • Fastest Bulk Macro Performance (up to 100 times faster than all other products)
  • Optimised ITL/CTL Erase Macro (Minimal End User Disruption)
  • Improved Performance for Cluster Scan
  • Ability to Cancel Pending/Bulk Actions
  • Maximum Efficiency Automatic Screenshots
  • New Highly Flexible License Mechanism (Trial PhoneView using specific IP Phones)
  • Updated Simple Setup Rules to Support Older CUCM Versions
  • Improved Automatic software updates

New and Changed Information for Version 4.0.12.128

  • Improvement to exception decoding

New and Changed Information for Version 4.0.11.124

  • Included Additional PC Port Information - Port Speed, CRC Errors & RX Packets to Data View and Export
  • Included Additional PC Port Information - PCPortRXAlign, PCPortRXShort, PCPortTXTotal & PCPortTXCollision to Export

New and Changed Information for Version 4.0.10.118

  • Improvements to Exception Handling
  • Added Phone Estate Usage to License Install Form
  • Increse default concurrency levels

New and Changed Information for Version 4.0.9.112

  • Fix rare ITL/CTL Delete Macro Issue
  • Fix KeyPad Issue with the 7937 Model

New and Changed Information for Version 4.0.8.111

  • Fix off-line cluster activation issue

New and Changed Information for Version 4.0.7.104

  • Fix issue relating to hard-coded url

New and Changed Information for Version 4.0.6.103

  • Fix rare license issue relating to corrupt license keys

New and Changed Information for Version 4.0.5.101

  • Initial public 4.0 release
  • Improve UI feedback on deactivated license keys
  • Fixed ITL Macro for 7906/7911 model IP Phone

New Information for Version 4.0.4.98

  • One click to able to enable screenshots for all visible devices

New Information for Version 4.0.3.90

  • Enabled Policy Feature for Enterprise Edition
  • Finalised enforcement of Policies for Group Members

New Information for Version 4.0.2.89

  • Added ability to bulk enable automatic screenshots (replaced in 4.0.3.90 with all visible devices)
  • Fixed issue that prevented the use of the Admin Phone for Remote Audio monitoring/coaching
  • Disabled logging of results when scanning cluster, optional to re-enable
  • Improved speed of cluster scan
  • Fixed rare issue that could cause ITL/CTL Delete macro to not send all key presses
  • Disabled restriction that required Simple Setup to run on a PVD file
  • Fixed issue where phone data updates were not perform on the UI Thread causing crashed during Scan and other operations
  • Improve error reporting captures

On 23 Jun 2014, at 23:20, Stephen Welsh <stephen.welsh@unifiedfx.commailto:stephen.welsh@unifiedfx.com> wrote:

Hi Rhys,

No worries, I didn't do it for the credit ;)

I struggle with handling git checkin’s too, fantastic source control, just takes a bit to master ;)

In-fact this project inspired me with a recent requirement to automatically publish release notes to Zendesk when building (we use Team City for our CI), so we now upload to Azure and publish release notes all part of the build process.

I’ve given you access to the private MSBuildZendesk (https://github.com/unifiedfx/MSBuildZendesk) repo, I’m planning to make it public, but I need to get agreement from the other Directors before hand.

As part of using these with our build process I also have plans to include meta-data support in the MSBuildAzure code so I can embed the URL for the release notes against the published MSI file, so our secure download service that sits in-front of the Azure Storage blob (where the compiled project is uploaded too) can also direct users to the release notes for the download by reading the files meta data….

Thanks

Stephen

On 23 Jun 2014, at 23:06, Rhys Godfrey <notifications@git.luolix.topmailto:notifications@github.com> wrote:

Thank you for the PR and updating the library [:+1:] Sorry it took so long to close, I haven't checked this repo for a while. I've merged the changes in, unfortunately couldn't automatically merge from the pull request, and so had to merge manually, think I may have made a mess of this, and the commit is now against my user.

I've added a thanks to the README, if you want the commit correctly assigned to you sure we can figure something out (think the manually merge can be reverted, then merge into your copy and resubmit the PR).

Thanks again for your help, and apologies for the delay and merge issue.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-46908591.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants