-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DestinationFolder Parameter to specify the destination folder on A... #2
Conversation
Thank you for the PR and updating the library 👍 Sorry it took so long to close, I haven't checked this repo for a while. I've merged the changes in, unfortunately couldn't automatically merge from the pull request, and so had to merge manually, think I may have made a mess of this, and the commit is now against my user. I've added a thanks to the README, if you want the commit correctly assigned to you sure we can figure something out (think the manually merge can be reverted, then merge into your copy and resubmit the PR). Thanks again for your help, and apologies for the delay and merge issue. |
Hi Rhys, No worries, I didn't do it for the credit ;) I struggle with handling git checkin’s too, fantastic source control, just takes a bit to master ;) In-fact this project inspired me with a recent requirement to automatically publish release notes to Zendesk when building (we use Team City for our CI), so we now upload to Azure and publish release notes all part of the build process. I’ve given you access to the private MSBuildZendesk (https://github.com/unifiedfx/MSBuildZendesk) repo, I’m planning to make it public, but I need to get agreement from the other Directors before hand. As part of using these with our build process I also have plans to include meta-data support in the MSBuildAzure code so I can embed the URL for the release notes against the published MSI file, so our secure download service that sits in-front of the Azure Storage blob (where the compiled project is uploaded too) can also direct users to the release notes for the download by reading the files meta data…. Thanks Stephen On 23 Jun 2014, at 23:06, Rhys Godfrey <notifications@git.luolix.topmailto:notifications@github.com> wrote: Thank you for the PR and updating the library [:+1:] Sorry it took so long to close, I haven't checked this repo for a while. I've merged the changes in, unfortunately couldn't automatically merge from the pull request, and so had to merge manually, think I may have made a mess of this, and the commit is now against my user. I've added a thanks to the README, if you want the commit correctly assigned to you sure we can figure something out (think the manually merge can be reverted, then merge into your copy and resubmit the PR). Thanks again for your help, and apologies for the delay and merge issue. — |
I forgot to include, here is a sample of our automatically published release notes: http://support.unifiedfx.com/entries/73777637-PhoneView-4-1-0-168-Release-Notes This comes from the releasenotes.txt file we include in our product, it’s formatted as Markdown which is readable enough directly by the end users, but also generates well formatted HTML for the forum post ;) New Functionality Introducted in PhoneView 4.1
Download PhoneView 4.1.0.168New and Changed Information for Version 4.1.0.168
New and Changed Information for Version 4.1.0.165
New Functionality Introducted in PhoneView 4.0
New and Changed Information for Version 4.0.12.128
New and Changed Information for Version 4.0.11.124
New and Changed Information for Version 4.0.10.118
New and Changed Information for Version 4.0.9.112
New and Changed Information for Version 4.0.8.111
New and Changed Information for Version 4.0.7.104
New and Changed Information for Version 4.0.6.103
New and Changed Information for Version 4.0.5.101
New Information for Version 4.0.4.98
New Information for Version 4.0.3.90
New Information for Version 4.0.2.89
On 23 Jun 2014, at 23:20, Stephen Welsh <stephen.welsh@unifiedfx.commailto:stephen.welsh@unifiedfx.com> wrote: Hi Rhys, No worries, I didn't do it for the credit ;) I struggle with handling git checkin’s too, fantastic source control, just takes a bit to master ;) In-fact this project inspired me with a recent requirement to automatically publish release notes to Zendesk when building (we use Team City for our CI), so we now upload to Azure and publish release notes all part of the build process. I’ve given you access to the private MSBuildZendesk (https://github.com/unifiedfx/MSBuildZendesk) repo, I’m planning to make it public, but I need to get agreement from the other Directors before hand. As part of using these with our build process I also have plans to include meta-data support in the MSBuildAzure code so I can embed the URL for the release notes against the published MSI file, so our secure download service that sits in-front of the Azure Storage blob (where the compiled project is uploaded too) can also direct users to the release notes for the download by reading the files meta data…. Thanks Stephen On 23 Jun 2014, at 23:06, Rhys Godfrey <notifications@git.luolix.topmailto:notifications@github.com> wrote: Thank you for the PR and updating the library [:+1:] Sorry it took so long to close, I haven't checked this repo for a while. I've merged the changes in, unfortunately couldn't automatically merge from the pull request, and so had to merge manually, think I may have made a mess of this, and the commit is now against my user. I've added a thanks to the README, if you want the commit correctly assigned to you sure we can figure something out (think the manually merge can be reverted, then merge into your copy and resubmit the PR). Thanks again for your help, and apologies for the delay and merge issue. — |
Just a minor addition to simplify to selection of the upload destination folder