Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit special characters able to be used when generating the password. #13

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

dgoodellrhy
Copy link
Contributor

MySQL in RDS does not allow '"', ' ', '@', '/'
When generating passwords, Limit available special chars.

…MySQL in RDS does not allow '"', ' ', '@', '/'
@dgoodellrhy dgoodellrhy requested a review from a team as a code owner November 13, 2023 23:03
@dgoodellrhy
Copy link
Contributor Author

A little torn on how to implement this actually. I initially thought it should be a default behavior but that means existing databases won't be able to avail themselves of any further changes. Maybe I should allow the old behavior behind a variable so this doesn't try to recreate old passwords?

@dgoodellrhy
Copy link
Contributor Author

decided on making the special char override a variable with a sane default. can be overrided to "" and this will replicate the old behavior

@dgoodellrhy dgoodellrhy merged commit 8122e35 into master Nov 14, 2023
4 of 7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix_special_chars branch November 14, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants