Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write react hook components and code refactoring #91

Merged
merged 13 commits into from
Apr 1, 2022
Merged

Write react hook components and code refactoring #91

merged 13 commits into from
Apr 1, 2022

Conversation

SaoussenBlk
Copy link
Contributor

@SaoussenBlk SaoussenBlk commented Mar 29, 2022 •
edited
Loading

#71 #73

Front tasks :

  • Write hooks
  • Fix RTL notification with progress expiration bar
  • Factorise frontend code to reduce duplication
  • Factorise install and web apps into one single app
  • Add frontend routing file

Back tasks :

  • Factorise backend code to reduce duplication
  • Harmonise HTTP responses codes
  • Add virtual field to user modal
  • Add hivelvet bash function to activate/deactivate install

Choices of HTTP responses codes :

  • HTTP_OK : success response
  • HTTP_CREATED : new object created
  • HTTP_BAD_REQUEST : invalid data
  • HTTP_NOT_FOUND : not found data
  • HTTP_PRECONDITION_FAILED : existing fields errors
  • HTTP_UNPROCESSABLE_ENTITY : form validation errors
  • HTTP_INTERNAL_SERVER_ERROR : exceptions occurred

GhaziTriki
GhaziTriki requested changes Mar 30, 2022
View reviewed changes
@SaoussenBlk SaoussenBlk requested a review from GhaziTriki March 30, 2022 16:54
GhaziTriki
GhaziTriki requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@GhaziTriki GhaziTriki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaoussenBlk Can you please update the PR comment to explain the choices regarding HTTP status responses?

@GhaziTriki GhaziTriki added this to the 0.6 milestone Mar 31, 2022
@GhaziTriki
Copy link
Member

I confirm build time has been improved by properly using the "define" plug-in of web-pack. Build time reduced from ~60s to ~30s.

@SaoussenBlk SaoussenBlk requested a review from GhaziTriki April 1, 2022 08:56
@SaoussenBlk SaoussenBlk changed the title Write react hook components Write react hook components and code refactoring Apr 1, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

GhaziTriki
GhaziTriki approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@GhaziTriki GhaziTriki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except some complexity in Roles.tsx than can be improved later.

@GhaziTriki GhaziTriki merged commit 431b8ea into riadvice:develop Apr 1, 2022
@SaoussenBlk SaoussenBlk deleted the hook-components branch November 29, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhaziTriki GhaziTriki GhaziTriki approved these changes

Assignees

@SaoussenBlk SaoussenBlk

Labels
None yet
Projects
BBBEasy Release 1.0.0
Status: Done
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@SaoussenBlk @GhaziTriki