Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Disable SSL and Force Path Style options. #5

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

maxpospelov
Copy link

@maxpospelov maxpospelov commented Jul 2, 2019

Hello, I had a task to deploy the S3 exporter and integrate with our local minio service.
I have added new variable for that.
Thank you for your work and maybe my little update will be helpful for you too.

Copy link
Owner

@ribbybibby ribbybibby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please document these options in the README?

s3_exporter.go Show resolved Hide resolved
@maxpospelov
Copy link
Author

Can you please document these options in the README?

I documented these options in the README.

@maxpospelov
Copy link
Author

@ribbybibby Can you check it please?

Copy link
Owner

@ribbybibby ribbybibby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxpospelov. Sorry for the long wait; it looks good to me.

@ribbybibby ribbybibby merged commit fdf2ad7 into ribbybibby:master Aug 16, 2019
@snqk
Copy link

snqk commented Aug 1, 2020

@ribbybibby could you make a release & update dockerhub for this commit please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants