Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting server_name as query parameter #80

Conversation

johanfleury
Copy link
Contributor

Implements #74

@johanfleury johanfleury force-pushed the feature/support-server-name-query-param branch from a7eef4d to 978a8a8 Compare December 13, 2021 15:56
@ribbybibby
Copy link
Owner

The same proposal has been rejected in the blackbox_exporter: prometheus/blackbox_exporter#624.

I'm sympathetic to the reasoning there that this issue can be solved by configuration management.

@k0ste
Copy link

k0ste commented Aug 9, 2022

I agree that this possible to cover cases like this via IaC, in per-module manner. We do it like this with ssl_exporter Ansible role

@johanfleury
Copy link
Contributor Author

I’m closing the PR as I’m not using ssl_exporter that way anymore since I left my previous company.

I still think that having to manage a configuration file is a pain, especially when you already have everything you need in the service discovery labels.

Of course everything is always possible (depending on the time you’re willing to put into it), but managing the configuration dynamically in the Kubernetes context (in which this issue arose) is not the simplest thing to do.

@ldaneliukas
Copy link

@ribbybibby seeing as blackbox_exporter now accepts hostname as a parameter, can this be re-opened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants