Skip to content

Commit

Permalink
Remove target and Require
Browse files Browse the repository at this point in the history
  • Loading branch information
ricaun committed Dec 17, 2024
1 parent 0ff874f commit 087ceeb
Show file tree
Hide file tree
Showing 8 changed files with 2 additions and 56 deletions.
2 changes: 0 additions & 2 deletions Build/Build.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,4 @@
<ProjectReference Include="..\ricaun.Nuke\ricaun.Nuke.csproj" />
</ItemGroup>

<!--<Import Project="..\ricaun.Nuke\build\ricaun.Nuke.targets" />-->

</Project>
13 changes: 0 additions & 13 deletions Build/IAzureSignTool.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
using Nuke.Common;
using Nuke.Common.Tools.AzureSignTool;
using Nuke.Common.Tools.GitVersion;
using Nuke.Common.Tools.NuGet;
using ricaun.Nuke.Components;
using ricaun.Nuke.Tools.NuGetKeyVaultSignTool;

Expand All @@ -10,22 +8,11 @@ public interface IAzureSignTool : IClean, ICompile
Target AzureSignTool => _ => _
.TriggeredBy(Clean)
.Before(Compile)
//.Requires<NuGetKeyVaultSignToolTasks>()
//.Requires<AzureSignToolTasks>()
//.Requires<GitVersionTasks>()
//.Requires<NuGetTasks>()
.Executes(() =>
{
ricaun.Nuke.Tools.AzureSignToolUtils.EnsureAzureToolIsInstalled();

Serilog.Log.Information(AzureSignToolTasks.AzureSignToolPath);
Serilog.Log.Information(NuGetKeyVaultSignToolTasks.NuGetKeyVaultSignToolPath);

//Serilog.Log.Information("DownloadAzureSignTool");
//ricaun.Nuke.Tools.AzureSignToolUtils.DownloadNuGetKeyVaultSignTool();
//Serilog.Log.Information("DownloadNuGetKeyVaultSignTool");

//ricaun.Nuke.Tools.AzureSignToolUtils.EnsureAzureToolIsInstalled();
//Serilog.Log.Information("EnsureAzureToolIsInstalled");
});
}
5 changes: 0 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Enable sign files using `Azure Key Vault`.
### Build
- Add `IAzureSignTool` to check if `AzureSignToolUtils` is installed.
- [ ] Update `IAzureSignTool` with `Requires`.
- [ ] Add import `build` with `.targets`
### Updates
- Add version `Information` in the `CommonExtension`.
- Add `AzureSignToolUtils` to sign files using `AzureSignToolTasks` or `NuGetKeyVaultSignToolTasks`.
- Add `NuGetKeyVaultSignTool` for nuke version `8.*`.
- Add `AzureKeyVaultConfig` with json file with `Azure Key Vault` without secrets.
- [ ] Add `build` with `.targets` to install packages `AzureSignTool` and `NuGetKeyVaultSignTool`.
- Add `PackageDownload` to download `AzureSignTool` and `NuGetKeyVaultSignTool` on the fly.
- [ ] Update `IClear` with `CreateTemporaryIgnore`.
- [ ] Update `ISign` with `Requires`.
- Add `HttpAuthTasks` to get/post files.
- Update `HttpAuthTasks` docs.
- Update `IsPathTooLong` to equal or greater than `260`.
Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project>
<PropertyGroup>
<Version>1.9.0-beta.5</Version>
<Version>1.9.0-beta.6</Version>
</PropertyGroup>
</Project>
12 changes: 1 addition & 11 deletions ricaun.Nuke/Components/IClean.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using Nuke.Common;
using Nuke.Common.IO;
using ricaun.Nuke.Extensions;

namespace ricaun.Nuke.Components
Expand All @@ -15,16 +14,7 @@ public interface IClean : IHazSolution, INukeBuild
Target Clean => _ => _
.Executes(() =>
{
//CreateTemporaryIgnore();
Solution.ClearSolution(BuildProjectDirectory);
});


private void CreateTemporaryIgnore()
{
var tempIgnore = TemporaryDirectory / ".." / ".gitignore";
if (!tempIgnore.FileExists())
tempIgnore.WriteAllText("temp");
}
}
}
}
4 changes: 0 additions & 4 deletions ricaun.Nuke/Components/ISign.cs
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
using Nuke.Common;
using Nuke.Common.IO;
using Nuke.Common.ProjectModel;
using Nuke.Common.Tools.AzureSignTool;
using Nuke.Common.Utilities.Collections;
using ricaun.Nuke.Extensions;
using ricaun.Nuke.Tools.NuGetKeyVaultSignTool;

namespace ricaun.Nuke.Components
{
Expand All @@ -18,8 +16,6 @@ public interface ISign : ICompile, IHazSign, IHazSolution, INukeBuild
/// </summary>
Target Sign => _ => _
.TriggeredBy(Compile)
//.Requires<NuGetKeyVaultSignToolTasks>()
//.Requires<AzureSignToolTasks>()
.Executes(() =>
{
SignProject(MainProject);
Expand Down
15 changes: 0 additions & 15 deletions ricaun.Nuke/build/ricaun.Nuke.targets

This file was deleted.

5 changes: 0 additions & 5 deletions ricaun.Nuke/ricaun.Nuke.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,4 @@
<PackageReference Include="Nuke.Common" Version="8.1.4" />
</ItemGroup>

<ItemGroup>
<Folder Include="build\" />
<!--<None Include="build\$(MSBuildProjectName).targets" PackagePath="build" Pack="true" />-->
</ItemGroup>

</Project>

0 comments on commit 087ceeb

Please sign in to comment.