Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display to code when saving as_svg = TRUE #503

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Nov 8, 2023

Fix #492

Naive fix, (harmless) doesn't change anything ) working on refactoring the render_graph() code to silence some tibble related warnings, but thought I'd send this as a separate PR.

I ran into an error that only shows up when dev (with load_all() when testing this. (that I do not understand)

<std::runtime_error> with text:
  ReferenceError: Viz is not defined
Warnings
In file(con, "r") :
  file("") accepts only open = "w+" and open = "w+b" : using the first one

If you have an idea what it means, please let me know.

But I was able to test it successfully by installing the dev version of DIagrammeR locally.

@rich-iannone
Copy link
Owner

This seems like an issue with GraphViz (through our viz.js, which incidentally should be updated). Seems like there is an open issue concerning this (but seems benign for us?).

Copy link
Owner

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit 8ae1276 into rich-iannone:main Nov 9, 2023
9 checks passed
@olivroy olivroy deleted the issue-follow branch November 9, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

as_svg produces `object 'display' not found' error
2 participants