Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have promiseCallback make callbacks and promises behave the same #302

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Have promiseCallback make callbacks and promises behave the same #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/utilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,19 @@ const errorFunc = (resolve, reject) => isFunc(reject) ? reject : resolve;

/**
* Return a callback function for promise resole/reject args.
* Ensures that callback is called only once.
* @returns {Function}
*/
const promiseCallback = (resolve, reject) => {
return err => err ? errorFunc(resolve, reject)(err) : resolve();
let hasFired = false;
return (err) => {
if (hasFired) {
return;
}

hasFired = true;
return err ? errorFunc(resolve, reject)(err) : resolve();
};
};

/**
Expand Down Expand Up @@ -177,8 +186,9 @@ const saveBufferToFile = (buffer, filePath, callback) => {
};
// Setup file system writable stream.
let fstream = fs.createWriteStream(filePath);
fstream.on('error', err => callback(err));
fstream.on('close', () => callback());
console.log("Calling saveBuffer");
fstream.on('error', err => (console.log("err cb"), callback(err)));
fstream.on('close', () => (console.log("close cb"), callback()));
// Copy file via piping streams.
readStream.pipe(fstream);
};
Expand Down