Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix richardgirges/express-fileupload#342 URI malformed error #343

Closed
wants to merge 1 commit into from

Conversation

boly38
Copy link

@boly38 boly38 commented Dec 15, 2022

Fix #342 URI malformed error

HowTo reproduce source: https://stackoverflow.com/questions/28063750/decodeuricomponent-throwing-an-error-uri-malformed HowTo prevent invalid character credit: https://stackoverflow.com/questions/2670037/how-to-remove-invalid-utf-8-characters-from-a-javascript-string

Thanks: T.J. Crowder
Thanks: Phylogenesis
Thanks: loretoparisi


To reviewer remark

  • I'm not fan of catching error without feedback. : // ignore decode error
  • If you would like introduce an option (infoOnInvalidFilename) to log semthing that could be great too.. I dont know...
    anyway dont hesitate to amend or append to this fix directly.

@boly38
Copy link
Author

boly38 commented Dec 15, 2022

  • oO sorry I've some tests to fix :) (will see that in next days..)

  • Dec16: my side I dont get why the lintandcoverage circleci stage failed ?

> nyc report --reporter=text-lcov | coveralls


/home/circleci/project/node_modules/coveralls/bin/coveralls.js:19
      throw err;
      ^
Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}
(Use `node --trace-uncaught ...` to show where the exception was thrown)

Exited with code exit status 1
CircleCI received exit code 1

maybe COVERALLS_REPO_TOKEN (to refresh) issue?

HowTo reproduce source: https://stackoverflow.com/questions/28063750/decodeuricomponent-throwing-an-error-uri-malformed
HowTo prevent invalid character credit: https://stackoverflow.com/questions/2670037/how-to-remove-invalid-utf-8-characters-from-a-javascript-string

Thanks: T.J. Crowder
Thanks: Phylogenesis
Thanks: loretoparisi

fix test, lint and remove replaceAll
@boly38
Copy link
Author

boly38 commented Feb 20, 2023

any news/hint @richardgirges @duterte ?

@RomanBurunkov
Copy link
Collaborator

Hi @boly38

Closing this, since it was fixed with #356
Thanks a lot for your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upload attack surface - URI malformed error
2 participants