Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strong name to assembly #1

Closed
jozefizso opened this issue Nov 21, 2014 · 5 comments
Closed

Add strong name to assembly #1

jozefizso opened this issue Nov 21, 2014 · 5 comments
Milestone

Comments

@jozefizso
Copy link
Contributor

Could you add a strong name to the MockHttp assembly, so it can be referenced from unit testing projects that are strongly named?

@richardszalay
Copy link
Owner

@jozefizso Is this still a requirement? Microsoft seems to be moving away from strong naming for third party components (https://github.com/dotnet/corefx/wiki/Strong-Naming), so I'd rather not go down that path unless it's really necessary.

@jozefizso
Copy link
Contributor Author

No, it is not necessary to add strong name. Unit test projects does not have to be strongly named.

@oschwald
Copy link

oschwald commented Sep 8, 2015

I ran into a situation where this would be very useful. When you make your unit tests a friend assembly, using InternalsVisibleTo, with a strongly named assembly, your unit tests do need to be strongly named. Would you accept a PR to add strong naming?

@richardszalay richardszalay reopened this Feb 22, 2019
@richardszalay
Copy link
Owner

richardszalay commented Feb 22, 2019

I've decided to go ahead with this (granted, 3.5 years later) because:

  1. It's highly unlikely that anyone will want to upgrade
  2. There's not much in the way of "MockHttp extension" libraries, so binding redirects for netfx really aren't a problem

@richardszalay
Copy link
Owner

Released in 6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants