Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Allow ASR profile and audio format to be specified #33

Merged
merged 1 commit into from
Feb 3, 2019

Conversation

richtier
Copy link
Owner

@richtier richtier commented Feb 3, 2019

@codecov
Copy link

codecov bot commented Feb 3, 2019

Codecov Report

Merging #33 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage    96.3%   96.35%   +0.04%     
==========================================
  Files          10       10              
  Lines         271      274       +3     
==========================================
+ Hits          261      264       +3     
  Misses         10       10
Impacted Files Coverage Δ
alexa_client/alexa_client/connection.py 97.36% <ø> (ø) ⬆️
alexa_client/alexa_client/client.py 95.23% <100%> (ø) ⬆️
alexa_client/alexa_client/constants.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b7276...7fd925e. Read the comment docs.

def send_audio_file(self, audio_file, dialog_request_id=None):
def send_audio_file(
self, audio_file, dialog_request_id=None,
distance_profile=constants.CLOSE_TALK, audio_format=constants.PCM
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventually a refactor to device_manage will be done that allows the device manager to handle the distance_profile, audio_format and device status

@richtier richtier merged commit b423d0d into master Feb 3, 2019
@richtier richtier deleted the non-fixed-profile branch February 3, 2019 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant